txw8301-openipc: add Taixin TXW8301 802.11ah HaLow Wi-Fi FMAC driver package#2043
txw8301-openipc: add Taixin TXW8301 802.11ah HaLow Wi-Fi FMAC driver package#2043csvke wants to merge 1 commit into
Conversation
flyrouter
left a comment
flyrouter
left a comment
There was a problem hiding this comment.
Good afternoon
Thank you very much for your interest in our project and your contribution.
Your PR will be reviewed shortly by our team.
A brief review of your files
Files that can be accepted into the Firmware repository immediately:
- general/package/Config.in
- general/package/txw8301-openipc/Config.in
- general/package/txw8301-openipc/files/S35txw8301
- general/package/txw8301-openipc/hgicf.conf.default
- general/package/txw8301-openipc/hgicf_sdio.bin
- general/package/txw8301-openipc/modprobe-txw8301.conf
- general/package/txw8301-openipc/txw8301-openipc.mk
Regarding the two files:
- br-ext-chip-goke/configs/gk7205v300_ultimate_defconfig
- br-ext-chip-sigmastar/configs/ssc338q_ultimate_defconfig
We would not like to include them in the current configuration of the Ultimate firmware for the following reasons:
- It is possible that after some time the Ultimate firmware strategy itself will be changed or they may be abolished altogether.
- If we accept your PR for these two files, any users who have installed the Ultimate firmware will have drivers inside that they may never need.
We suggest an alternative approach:
- Remove these two files from your PR and it will be accepted immediately.
- Please take a look at the Builder repository, and it might be more appropriate to create your two HaLow configurations there and maintain them under your guidance and management. We believe this is the right approach and will give you more freedom of action.
Please do not hesitate to comment on the suggestion.
Thank you for your contribution!
csvke
force-pushed
the
add-txw8301-halow-support
branch
from
1557927 to
3030002
Compare
…package Adds Buildroot package under general/package/txw8301-openipc with firmware blobs, default config, and init script; enables TXW8301 on gk7205v300_ultimate and ssc338q_ultimate.
csvke
force-pushed
the
add-txw8301-halow-support
branch
from
3030002 to
62f4029
Compare
|
Thank you for the thorough review and for the thoughtful suggestion regarding the defconfig files. Sorry I have been tied up with other stuff. I have removed br-ext-chip-goke/configs/gk7205v300_ultimate_defconfig and br-ext-chip-sigmastar/configs/ssc338q_ultimate_defconfig from the PR. The branch now contains only the package files as listed in your accepted list. Regarding the Builder repository approach — I agree this makes more sense for board-specific HaLow configurations, as it keeps them decoupled from the Ultimate firmware strategy and allows them to be maintained independently. I will look into creating the two HaLow configurations there. The PR should now be ready for acceptance at your convenience. Please let me know if any further changes are needed. Thank you again for your guidance! |
2 participants
Adds a Buildroot package under
general/package/txw8301-openipcwith firmware blobs, default config, and init script. Also enables TXW8301 ongk7205v300_ultimateandssc338q_ultimate.TXW8301 FMAC firmware: https://github.com/TXW8301/TXW8301-FMAC-SDK
TXW8301 Linux Driver: https://github.com/TXW8301/TXW8301-FMAC-linux-driver
Tested on a
XM IVG-G5FGK7205V300camera board using it'sJ3 Extension portsfor both SDIO and USB interfaces connecting withTAIXIN-AH-RX00P_EVB_V1.7@cronyx @flyrouter @viktorxda